-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Note that lnotab_notes.txt is only valid before 3.11 #107961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a pointer to Objects/locations.md, the line table document for 3.11+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that preserving documentation in 3.13 that is only valid for 3.10 and before is of questionable value. Should we just remove this file from 3.13 instead? We can change the note at the top of locations.md
to say "For versions up to 3.10 see Objects/lnotab_notes.txt
in a 3.12 or earlier source tree".
But this PR is clearly an improvement on the status quo. And since these aren't even public-facing docs, just effectively big code comments, I think this PR qualifies for both "skip news" and "skip issue."
Co-authored-by: Carl Meyer <[email protected]>
|
Agreed. Removal (even back to 3.11) makes sense to me. |
Adds a pointer to Objects/locations.md, the line table document for 3.11+